Fix variable name typo in similarity_distance function#26
Merged
YoanSallami merged 1 commit intoSynaLinks:mainfrom Oct 16, 2025
Merged
Conversation
Contributor
|
Thanks, I didn't catch it! |
Contributor
|
Don't hesitate to star the project, that helps a lot :) thank you again ! |
RamXX
pushed a commit
to RamXX/synalinks
that referenced
this pull request
Jan 23, 2026
…tance-bug Fix variable name typo in similarity_distance function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thanks for building and sharing Synalinks! :)
Fixes incorrect variable assignment in
similarity_distancefunction that causes all candidate distances to evaluate to ~0, breaking OMEGA's DNS mechanism.Variable name typo at line 142:
Before:
After:
One-character fix to assign to the correct variable!